hpodder icon indicating copy to clipboard operation
hpodder copied to clipboard

Don't use ~/.curlrc options

Open kevinoid opened this issue 11 years ago • 0 comments

In the case that ~/.hpodder/curlrc does not exist, the -K option is not passed to curl and curl will read the user's ~/.curlrc for options. This can cause difficult to diagnose problems when ~/.curlrc includes options which hpodder does not expect.

This is a backwards-incompatible change for users with ~/.curlrc and without ~/.hpodder/curlrc which contains options not overridden by the curl invocation from hpodder. I contend that this is less painful than continuing to support this behavior going forwards, both because it is undocumented and because it can cause rather inscrutable problems for unsuspecting users.

Note: This patch changes the order of curlrcopts and curlopts, because -q must be the first option. None of the other options used are position-sensitive.

Signed-off-by: Kevin Locke [email protected]

kevinoid avatar May 25 '13 04:05 kevinoid