ftphs icon indicating copy to clipboard operation
ftphs copied to clipboard

Make getbinary return ByteString

Open Xandaros opened this issue 6 years ago • 2 comments

I also removed the unsafeInterleaveIO part because I don't know what it does. Seems to work without it.

If it does something crucial which I'm missing, you'll have to add it yourself, since I don't know how to do that with ByteStrings.

Xandaros avatar Jul 27 '17 22:07 Xandaros

I think the one feedback I would add is to add a new function that returns a ByteString, rather than remove the existing one, such that we don't introduce an API incompatibility.

jgoerzen avatar Aug 01 '17 17:08 jgoerzen

I would rather just bump major version. ByteString is the way to go and String arguably should almost never be used 😄

fizruk avatar Apr 24 '19 10:04 fizruk