John Neffenger

Results 44 comments of John Neffenger

@kevinrushforth I found the Makefiles building the media libraries for Windows. I can fix those, but there's also `libxml` and `libxslt` that invoke the Windows linker here: ``` modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/win32/Makefile.msvc modules/javafx.web/src/main/native/Source/ThirdParty/libxslt/src/win32/Makefile.msvc...

> IMHO, it would make sense to merge any clear improvement of the status-quo and debug+fix more in a later PR. I agree that we will have to draw the...

> Silly question, is the difference with Windows just the nature of the native support on each platform (Unix based vs Windows) and libraries used as part of that? That's...

> /contributor add ... @bmwiedemann I added you as co-author of pull request #422, which is my continuation of your pull request #99 from last year. This pull request #446...

> It would be better to add the flag in `libxml/CMakeLists.txt` or in `build.gradle` via `cmakeArgs`. Thank you, Arun, for that helpful suggestion. I updated this pull request for the...

Thank you, Alexander and Arun, for looking over the Makefiles and verifying the builds. > I'd like to take a week to get feedback and mull over the code changes...

*IEEE Software* just published a good article that describes the problems solved in part by this pull request. The article is called "Reproducible Builds: Increasing the Integrity of Software Supply...

> As an alternative, you could close that PR ... and list both issues in this PR ... I prefer to keep them separate because they have distinct attributions and...

### Notes The sequence of nested calls to the batch files is shown below, where `C:/Program Files (x86)/Microsoft Visual Studio` is the root directory of the Visual Studio files: ```...

> It would be more convenient to ask the developer set `VSCMD_DEBUG` via an env variable, rather than asking them to edit `win.gradle`. Thanks, Kevin. That is the most direct...