Jefferson González

Results 269 comments of Jefferson González

Updated this PR and as discussed above: * now build.yml doesn't enables addons * simplified build.yml since the release logic is now done on release.yml * restored non addon builds...

One minor issue I see is the windows path contains double back slashes on the readme: C:\\\Users\\\\(username)\\\\.config\\\lite-xl\\\plugins\\\ instead of Windows C:\Users\\(username)\\.config\lite-xl\plugins\ Also couldn't this be generalized to also include colors?...

> Can you split this into renderer.c? That'll hopefully remove FT dependency (directly) on `api/renderer.c` Done, I was initially going to do that but hesitated over the need of adding...

> Do we really need this in core? As far as I can see this is not used anywhere by us, right? It's not too much added code so it's...

> Yeah, but this is plugin territory. Easy font selection functionality is provided by most editors out of the box, if we can offer the same (and in the process...

> I don't think Atom and VSCode provide font pickers. They probably simply use fontconfig to provide font name/family matching. That is basically because those are developed using a web...

> Yeah, but if Atom, VSCode and Sublime Text can get away with not having to include a font picker, I'm sure we can too. In my opinion those are...

> what's the problem with fontconfig besides it being another dependency Seems like the only fontconfig dependencies are libexpat and libfreetype, it also has meson support as seen here ,...

I finished the font picker implementation and I think it is good enough, lets you pick from all fonts or only the ones detected as monospaced, plus it previews how...

I wonder if we should drop the dpi fall back and also allow the base resolution calculation for mac too