Jefferson González

Looking good! I would be interested on integrating this change into [Pragtical](https://github.com/pragtical/pragtical) once it is complete. There is a [meson.wrap for harfbuzz](https://wrapdb.mesonbuild.com/v2/harfbuzz_8.2.2-1/harfbuzz.wrap) that can be easily added for CI builds.

> Otherwise on my side it seems pretty good, everything is working smoothly and I do not see any drop in performances. Tested a little bit and it is working...

> Second of all now I slighty changed the way I load the hb fonts and changed the caching parameters. I think you forgot to push that change, I only...

Just in case this is what I mean with slower font loading: Non Ligatures: https://github.com/lite-xl/lite-xl/assets/1702572/74c14306-fd23-4044-a376-cd9d2bfb1505 With Ligatures https://github.com/lite-xl/lite-xl/assets/1702572/ecdefe50-28f1-460c-8cc3-73cee2d51930

> You are right! I forgot to push the commit! Ops! I will look into the fallbacks fonts issue (I believe to know the source of the problem and I...

Was experimenting with `GLYPHSET_SIZE` and it seems that setting it to `#define GLYPHSET_SIZE 8` is enough now with the use of harfbuzz, loading is even faster than originally.

Playing a bit more with the code and was able to get fallback fonts working again here is the patch: https://github.com/pragtical/pragtical/pull/39/commits/ed28c3ae7d079fe28f9cc174291a99db7789353a Edit: had to repush removal of debugging artifact

> I also succeeded to add back the fallback fonts support (let me know what do you think about my solution) :)  Great, this way seems more efficient. And...

> Both issues should be solved now! :D Whoa, I can confirm it works now! The fixes to tab size handling code now cause tabs to not be rendered as...

Just in case this change fixes the tab issue mentioned above, which I didn't properly look before commenting :disappointed: ```diff diff --git a/src/renderer.c b/src/renderer.c index bd6bf993..ba3398d3 100644 --- a/src/renderer.c +++...