John MacFarlane
John MacFarlane
Could we set `isLightTheme` automatically by checking backgroundColor on the style? If it's > 0x8000 we count it as a light theme?
All you have to do is `backgroundColor writerHighlightStyle opts` and it gives you a `Maybe Color` (where `Color = RGB Word8 Word8 Word8`. So we'd just need to write a...
Sorry for the delay. This looks fine! Can you also add the new options to the man page at man/citeproc.1.md? (And then run `make man/citeproc.1`.)
Very slick! Here's the one thought I have. We have a distinction between DefaultStyle and Decimal, which gets effaced by your code. Would it be better to make counterStyle a...
CONTRIBUTING.md says that we aim to support at least the last 3 ghc versions, and often more (currently back to 8.10). So, I think it would be safe to drop...
OK, I've dropped support for ghc < 9.6. Hopefully this allows us to streamline some things!
Possibly related: https://github.com/jgm/pandoc/pull/10914#issuecomment-2997095502 though I don't think autodocodecs covers XML schemas! I'm not sure what I think about this. Duplicating pandoc-types stuff in a separate package seems a bad idea....
I see, looking now at the changes, that this is not (yet anyway) about the Pandoc type, but about the types used for Options etc. Can you say more about...
You need to use `cmark_node_free` I think.