Jesse Glick

Results 496 comments of Jesse Glick

I think `build` could use `error` to let you know if the argument is clearly insane.

> it's also possible for the user to specify a tag in the tag and push methods, so I suspect we'd want the same error handling there Perhaps so. >...

Without the ability to reproduce this environment I cannot maintain such a patch. I am thinking of ways to deprecate (most of) this plugin altogether so users can run `docker`...

There is a `LauncherDecorator` system in Jenkins which plugins can implement but it is not set up in a way that a Pipeline script could contribute implementations, due to technicalities...

All the registry prefix handling is in a confused state, and I am not accepting any further changes to this code. You are advised to use `docker` CLI commands from...

So is this purporting to address [JENKINS-34289](https://issues.jenkins-ci.org/browse/JENKINS-34289) or not? And is there a self-contained demo case that can be used to prove that this change fixes some concrete bug? What...

> I found a bug in master with docker client 1.7.0, the bug was introduced in #54. The bug is that the redirection is causing the exit status to be...

> I performed an 'id' in the sh step and it was indeed the jenkins user (in my test instance, in the demo container the jenkins user is root). This...

> I would like to see/determine if the core logic of this plugin and the Docker Custom Build Environment plugin can be merged Given how fundamentally different Pipeline asynchronous (durable)...