Jesse Glick comments

Results 498 comments of


                                            Jesse Glick

System::setSecurityManager is deprecated and will be removed in a future JDK release

@io7m looks to be https://github.com/spotbugs/spotbugs-maven-plugin/issues/423

Allow setting a default push target for `pr create`

A hybrid of the two: when choosing a push target for the first time, _prompt_ whether to remember it for this repository (and also offer a command to undo or...

Allow setting a default push target for `pr create`

> rather than introducing a new GitHub-CLI-specific mechanism to achieve the same result I am not familiar with all the options available in Git here, but one way or another...

ACEGI Security: avoid temporary calls to SecurityContextHolder.getContext().setAuthentication(…)

Yes, a thread is only handling one request at a time, and the context is thread local. The problem is that a single `SecurityContext` object may be in use by...

ACEGI Security: avoid temporary calls to SecurityContextHolder.getContext().setAuthentication(…)

I am not very familiar with Spring Security but it seems `SecurityContextPersistenceFilter` uses the same basic mechanism. [The manual](http://static.springsource.org/spring-security/site/docs/3.1.x/reference/technical-overview.html#tech-intro-sec-context-persistence) warns about the exact vulnerability mentioned here, so it seems that...

ACEGI Security: avoid temporary calls to SecurityContextHolder.getContext().setAuthentication(…)

OK. On vacation for a bit but will keep this on my radar.

ACEGI Security: avoid temporary calls to SecurityContextHolder.getContext().setAuthentication(…)

Simply checking for ``` SecurityContextHolder.getContext().setAuthentication(…); ``` might suffice. I am not sure if there are legitimate use cases for this.

ACEGI Security: avoid temporary calls to SecurityContextHolder.getContext().setAuthentication(…)

Sorry for my slow responses here. I encountered the issue in Jenkins, which is still using an old version of ACEGI Security, so it is probably not the best source...

ACEGI Security: avoid temporary calls to SecurityContextHolder.getContext().setAuthentication(…)

OK that much I should be able to do, give me a week until I am slightly less busy…

[Idea] make it possible to use different contexts/namespaces in multiple shells

Another tool in this vein is `jx shell`: [docs](https://jenkins-x.io/commands/jx_shell/); [key bit of sources](https://github.com/jenkins-x/jx/blob/3b0a128b389a3e91dff759f7f711cecae634667c/pkg/cmd/shell.go#L134-L156)