Jesse Glick

Results 498 comments of Jesse Glick

Seems to be a build failure in `test_war_from_pom_with_timeout`; have not yet looked at what that means.

Since #20 has been merged, perhaps you should close this and refile just the test parts, to confirm that the fix works according to your tests? Or perhaps a new...

More inclined to just use the new terminology incrementally as changes are made, as in #428.

> why we want to run MRP in a cd fashion Merely to make it easier to cut release by pushing a button (or, perhaps, just merging an appropriately labeled...

Yes if you are using the built-in test storage,, giant test stdout/err is going to become giant `CDATA` blocks in XML and giant `String`s in Java heap and cause terrible...

Also: if you are in fact using another storage system, like an RDB :tada:, it may be perfectly reasonable to just dump a few megs of text into a test...

> money well spent. Wasting disk space for the same on successful builds I am little less happy about. Understood. I was just trying to give some historical background for...

I see no reason to hold off on this PR just because https://github.com/jenkinsci/jenkins/pull/4447 is stalled.

> it doesn't run `after()`. But that may be a good thing, since shutdown invokes user code and thus could hang, right?