connman-gtk icon indicating copy to clipboard operation
connman-gtk copied to clipboard

Some questions.

Open rilian-la-te opened this issue 7 years ago • 4 comments

What do you think about:

  1. Implementing StatusNotifier (no dependencies, except gdbus-codegen, which is bundled with GLib)
  2. Bumping required GTK version to GTK3.18 (or 3.22)
  3. Replacing GtkNotebook to GtkStack
  4. Adding .clang-format file to easier styling new code

rilian-la-te avatar Feb 09 '18 00:02 rilian-la-te

@jgke

SolarAquarion avatar Jun 25 '18 17:06 SolarAquarion

You may need to fork it?

SolarAquarion avatar Jun 25 '18 17:06 SolarAquarion

Whoops, forgot to reply to these, been quite busy with life... sorry about that.

Ahem.

  1. Sure! I originally went with GtkStatusIcon because it was available in GTK and was readily available.
  2. Why not, if there's need for it. Since 3.22 is already at Debian Stable, I guess it's pretty safe to upgrade directly to it :)
  3. Is there a reason for switching? GtkNotebook works fine in my opinion.
  4. Why not, the project tries to follow connman's coding style. Astyle/clang's formatter/whatever might make that easier.

jgke avatar Jun 25 '18 20:06 jgke

  1. I will try to implement it (but I need to port my local StatusNotifier library from Vala to C)
  2. 3.22 contains many new APIs, so, it worth to upgrade.
  3. For me, GtkStackSidebar is more beautiful than GtkNotebook and one stack can be bound to multiple tabs.
  4. Can you add .clang-format to this project?

rilian-la-te avatar Jun 25 '18 20:06 rilian-la-te