Newly created database is now identified by flag

[rasmusson]

Newly created database is now identified by flag instead of looking if the version number is 0

[rasmusson]

What do you think, can this be merged soon?

[jon-adams]

What is the purpose of this patch? In other words, why does using this flag instead of checking !=0 make things better? Are there any bugs with the version check as is? Or what scenarios will be better with this change?

[rasmusson]

I had an issue where the database version I was upgrading from was 0. With the old version no upgrade would be done

Stefan

On 16 May 2014 18:07, Jon Adams [email protected] wrote:

What is the purpose of this patch? In other words, why does using this flag instead of checking !=0 make things better? Are there any bugs with the version check as is? Or what scenarios will be better with this change?

— Reply to this email directly or view it on GitHubhttps://github.com/jgilfelt/android-sqlite-asset-helper/pull/30#issuecomment-43349230 .

[biegleux]

this is not an issue of the library database version number should start from 1, according to docs

[rasmusson]

No but it can be a problem if you have an earlier DB with version 0, as in my case

Stefan

On 28 April 2015 at 14:40, Tibor [email protected] wrote:

this is not an issue of the library database version number should start from 1, according to docs

— Reply to this email directly or view it on GitHub https://github.com/jgilfelt/android-sqlite-asset-helper/pull/30#issuecomment-97048325 .