42FileChecker icon indicating copy to clipboard operation
42FileChecker copied to clipboard

[NeedNewTest] 42filechecker doesn't check memory allocation on strjoin

Open EPgg92 opened this issue 6 years ago • 1 comments

#include "libft.h"

char	*ft_strjoin(char const *s1, char const *s2)
{
	char	*res;

	if (s1 == NULL || s2 == NULL)
		return (NULL);
	if (!(res = ft_strnew(ft_strlen((char *)s1 + ft_strlen((char *)s2 + 1))))) // +1 is very bad but 42fc don' t check it!
		return (NULL);
	res = ft_strcpy(res, s1);
	res = ft_strcat(res, s2);
	return (res);
}

Thx

EPgg92 avatar Oct 18 '18 13:10 EPgg92

Hello @EPgg92 The idea to check for leaks on "libft" project is nice. Are you interested in developing this test?

jgigault avatar Jan 13 '19 20:01 jgigault