John Gehrig

Results 154 comments of John Gehrig

Sorry to hear that :( I can relate. Here in the Northeastern States we were hit hard early and had aggressive shutdowns. No fun, strange times... Let me know when...

@alfredobarroso Friendly ping. I hope the COVID situation has improved for you!

@alfredobarroso Do you have the ability to test this on MacOS again? This *should* be ready for merge, but I'm not familiar with the Spanish keyboard layout. It would be...

@alfredobarroso Excellent. Thank you very much! That table is very helpful. One quick ask: can you add a `QKeyEvent` column? I just modified the PR to include some additional diagnostics...

I wish Qt had a better mechanism for detecting keyboard layout/localization... The remaining issues are `AltModifier` related, and very similar to #837 and #833. The `[` `{` and `\` characters...

> Maybe, but I'm not sure if that would break other layouts :( It will (to some degree). My `Alt + [` (US Layout) is identical to yours. We'll probably...

Here is an example of this issue... Actions + Windows lacks `ctest` failure output: https://github.com/equalsraf/neovim-qt/pull/885/checks?check_run_id=3094273084 AppVeyor + Windows correctly displays `ctest` output: https://ci.appveyor.com/project/equalsraf/neovim-qt/builds/40031037/job/ddhiyj6vtqyaclt9 The test binaries built by GitHub actions...

> Maybe a consequence of this check This was added intentionally to prevent this issue from causing build failures on GitHub Actions. Although it looks like you discovered this in...

This is good to see! :+1: Let me know if I can help in any way: testing, code-review, bug-fixes, etc.

@Melkster Thanks for the bug report! This is related to #851 and #856... Previously we behaved like gVim, and always rendered underline in `guifg`. Now we try to respect `guisp`...