vscode-todo-highlight icon indicating copy to clipboard operation
vscode-todo-highlight copied to clipboard

exclude doesn't exclude settings.json

Open ascheel opened this issue 1 year ago • 4 comments

todohighlight.exclude option doesn't seem to recognize settings.json. Screenshot shows what I mean. I don't want the highlight text highlighted in the settings file, just the raw text.

image

ascheel avatar Jul 24 '23 17:07 ascheel

It works for me however you need to click out of the file and back in for the highlighting to be removed.

GBR6000 avatar Jul 25 '23 18:07 GBR6000

Thanks, @ascheel for the report. It's also failing for me. So @GBR6000 interesting that it works for you. How many items are in your "todohighlight.exclude" array?

jgclark avatar Jul 28 '23 14:07 jgclark

image

"todohighlight.keywords": [ { "text": "\NewDocumentCommand", "color": "#569CD6", "backgroundColor": "transparent" }, { "text": "\...cite ", "regex": { "pattern": "(?<!(%.+))\\(\w+)?cite(?!\w)" }, "color": "#C586C0", "backgroundColor": "transparent", } ], "todohighlight.include": [ "/*.tex", "/*.json" ], "todohighlight.exclude": [ "**/settings.json" ],

GBR6000 avatar Jul 31 '23 11:07 GBR6000

Thanks, @GBR6000. As I thought: the first exclude setting works, but the others are currently ignored. I think this bug has been there since I forked it years ago, and we've only just noticed!

jgclark avatar Aug 01 '23 20:08 jgclark