SegWit

[libbitc]

Hi,

This PR adds SegWit functionality to picocoin. All json test files in test/data directory copied from bitcoin core 14.2

[coveralls]

Coverage increased (+0.2%) to 78.767% when pulling 3da980416a5ea0c268706a74d2e79efc946a0fcb on libbitc:picocoin into faa9b83a2cc9c3ba5f2cf4368e16681434128d2b on jgarzik:master.

[coveralls]

Coverage increased (+0.2%) to 78.767% when pulling 3da980416a5ea0c268706a74d2e79efc946a0fcb on libbitc:picocoin into faa9b83a2cc9c3ba5f2cf4368e16681434128d2b on jgarzik:master.

[jgarzik]

Nice! Thanks a bunch. concept ACK

Does the default-off sync test work on segwit or segwit2x testnet chains?

[libbitc]

Hi,

SegWit aside the default-off chain-verf test does not pass for testnet3 blocks:

chain-verf: validating testnet3 chainfile /bitcoin/bootstrap.testnet3.dat (*script)
chain-verf: spend block @ 0
chain-verf: spend block @ 5000
chain-verf: spend block @ 10000
chain-verf: spend block @ 15000
chain-verf: tx fail 970b18f67be0b86b8994223a87ef445431e5efc03fe2191034e9dad0c17dd6d3
chain-verf: block fail 16306 000000001531abe940a7983079579fa4e28217ec854b0189d184de744e475b88
chain-verf: chain-verf.c:164: read_test_msg: Assertion `!"spend_block"' failed.
FAIL chain-verf (exit status: 134)

This problem was introduced with changes made in commit 5475db7dd449930aa23eab61a6620bf1a68d3984.

Will add some fixes for this.

[coveralls]

Coverage increased (+0.2%) to 78.767% when pulling 24097bb37238385044a022f344f2024cf3ad0991 on libbitc:picocoin into faa9b83a2cc9c3ba5f2cf4368e16681434128d2b on jgarzik:master.

[coveralls]

Coverage increased (+0.2%) to 78.767% when pulling 24097bb37238385044a022f344f2024cf3ad0991 on libbitc:picocoin into faa9b83a2cc9c3ba5f2cf4368e16681434128d2b on jgarzik:master.

[coveralls]

Coverage increased (+0.1%) to 78.733% when pulling 7787e4c9dbee99286dac27dd1f0b7554455ab723 on libbitc:picocoin into faa9b83a2cc9c3ba5f2cf4368e16681434128d2b on jgarzik:master.

[libbitc]

Hi,

The most recent commit to this PR successfully validates 1179472 blocks of the testnet3 chain. The block time of block 1179472 is 2017-08-20 03:31:53. testnet3 supports SegWit as of block 834624.(2016-05-13 00:22:51)

chain-verf: validating testnet3 chainfile /libbitc/test/data/bootstrap.testnet3.dat.1179500 (+script)
chain-verf: spend block @ 0
chain-verf: spend block @ 5000
chain-verf: spend block @ 10000
chain-verf: spend block @ 15000
chain-verf: spend block @ 20000
chain-verf: spend block @ 25000
chain-verf: spend block @ 30000
.
.
.
chain-verf: spend block @ 80000
chain-verf: spend block @ 85000
chain-verf: spend block @ 90000
chain-verf: spend block @ 95000
chain-verf: spend block @ 100000
.
.
.
chain-verf: spend block @ 1150000
chain-verf: spend block @ 1155000
chain-verf: spend block @ 1160000
chain-verf: spend block @ 1165000
chain-verf: spend block @ 1170000
chain-verf: spend block @ 1175000
chain-verf: 1179472 records validated
PASS chain-verf (exit status: 0)

Test performed with FORCE_SCRIPT_VERF=1.

[libbitc]

Hi,

Non-standard indentations noted. .clang-format config seems to be doing some strange things. Will fix.

[coveralls]

Coverage decreased (-0.9%) to 77.642% when pulling 8a454a995db6860944db53b450c6fe8a437f5588 on libbitc:picocoin into faa9b83a2cc9c3ba5f2cf4368e16681434128d2b on jgarzik:master.

[coveralls]

Coverage decreased (-0.9%) to 77.642% when pulling 8fbaf2c9aa545ac57858ff8fb91ba2cb1b36d00c on libbitc:picocoin into faa9b83a2cc9c3ba5f2cf4368e16681434128d2b on jgarzik:master.