Jeff Garzik
Jeff Garzik
Checking in, because this possibly relates to one of my projects: is this PR still relevant? Thanks.
Initial reaction - it seems needlessly disruptive to search-and-replace gettext() calls with tr!(). The current code appears to be tested with un-mocked gettext by @fox0, making a cosmetic search and...
closing - can revisit later
@Wandalen Overall looks very good! What an ambitious contribution! Simple but large PR update, then I will merge: move this from ./display to its own ./man top-level directory and crate...
> btw @jgarzik what's the default locale in the tested machine? How to display the default locale? Here's some info, LMK if this is not sufficient, ``` $ locale -a...
Thanks for the patch. Quick review: ok, but should be applied across entire tree. We don't want to avoid atty in one util, yet use atty in another util.
thanks - looks like rust std isTerminal is the best approach
> > Review looks OK. > > In regards to testing, does the `-s` output match BSD or Linux diff? > > I'm not sure what the difference is, and...
@andrewliebenow @gcanat this is resolved and can be closed, yes?
Questions, 1) I see that BSD and Linux grep both have `-o`. Is this option widely used? 2) This is a significant change. Is there a performance impact, vs current...