shinysocks icon indicating copy to clipboard operation
shinysocks copied to clipboard

Fixes for ASIO >= 1.13 + fixed assertion when parsing SOCKS v header

Open bgolinvaux opened this issue 2 years ago • 1 comments

Recent versions of ASIO (I am using Boost 1.77) have removed the get_io_service() method. The get_executor() method can be used instead.

Also, in some cases, in Proxy::ParseV5Header, when copying parts of buffer to hdr_buffer, the remaining size was 0 and the C debug runtime complained because we took the address of the first element of the empty buffer (&hdr_buffer[0])

The first change is risky because it bumps the version requirement on ASIO, while the second change looks harmless.

bgolinvaux avatar Nov 14 '21 15:11 bgolinvaux

Looks good. I'll just have to test it with various versions of Linux. (Sorry for l o n g delay. I've been buried in work)

jgaa avatar Jan 04 '22 16:01 jgaa