jfrog-client-go icon indicating copy to clipboard operation
jfrog-client-go copied to clipboard

Bugfixes

Open Felioh opened this issue 1 year ago • 5 comments

This fixes some inconsistencies with the XRay API:

  • The Watch Recipients for Watches were missing: https://jfrog.com/help/r/xray-rest-apis/create-watch (In the documentation the curly braces are wrong)
  • The Due Diligance (License) report contains the license key in a json-field named 'license_key' not 'license'. https://jfrog.com/help/r/xray-rest-apis/get-due-diligence-report-content (Also incorrect in the documentation)

I suspect the source of these bugs is somewhere else since the documentation (and this client?) is generated?

  • [ ] All tests passed. If this feature is not already covered by the tests, I added new tests.
  • [ ] All static analysis checks passed.
  • [ ] This pull request is on the dev branch.
  • [ ] I used gofmt for formatting the code before submitting the pull request.

Felioh avatar May 16 '24 08:05 Felioh

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar May 16 '24 08:05 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

Felioh avatar May 16 '24 08:05 Felioh

don't think the other change is needed

What other change?

Felioh avatar Aug 13 '24 10:08 Felioh

don't think the other change is needed

What other change?

The Due Diligance (License) report contains the license key in a json-field named 'license_key' not 'license'. https://jfrog.com/help/r/xray-rest-apis/get-due-diligence-report-content (Also incorrect in the documentation)

so the right attribute is license_key no need to change

attiasas avatar Aug 14 '24 06:08 attiasas

Is there a reason, why this hasn't been merged?

Felioh avatar Nov 13 '24 17:11 Felioh