goroutine stack exceeds for GetUrl() method

[susannamartinelli]

HI, the call

rtDetails := auth.NewArtifactoryDetails()
rtDetails.SetUrl("https://my.artifactory-endpoint.com/artifactory/")
rtDetails.SetUser("admin")
rtDetails.SetPassword("mypasswd")
artconfig, err := artifactory.NewConfigBuilder().SetArtDetails(rtDetails).SetThreads(3).SetDryRun(false).Build()
if err != nil {
	panic(err)
}
cli, err := artifactory.New(&rtDetails, artconfig)
if err != nil {
	panic(err)
}
_, err = cli.Ping()
if err != nil {
	panic(err)
}
fmt.Println(cli.GetConfig().GetUrl())

causes a goroutine stack exceeds (infinite recursion I guess)

goroutine 1 [running]:
github.com/jfrog/jfrog-client-go/artifactory.(*artifactoryServicesConfig).GetUrl(0x9c94960, 0x0, 0x0)
	/home/susanna/go/pkg/mod/github.com/jfrog/[email protected]/artifactory/config.go:29 +0x3a fp=0x12400368 sp=0x12400364 pc=0x8548eaa
github.com/jfrog/jfrog-client-go/artifactory.(*artifactoryServicesConfig).GetUrl(0x9c94960, 0x0, 0x0)
	/home/susanna/go/pkg/mod/github.com/jfrog/[email protected]/artifactory/config.go:30 +0x21 fp=0x12400378 sp=0x12400368 pc=0x8548e91
github.com/jfrog/jfrog-client-go/artifactory.(*artifactoryServicesConfig).GetUrl(0x9c94960, 0x0, 0x0)
	/home/susanna/go/pkg/mod/github.com/jfrog/[email protected]/artifactory/config.go:30 +0x21 fp=0x12400388 sp=0x12400378 pc=0x8548e91
github.com/jfrog/jfrog-client-go/artifactory.(*artifactoryServicesConfig).GetUrl(0x9c94960, 0x0, 0x0)

I'm using v0.4.0. Thanks

[eyalbe4]

@susannamartinelli, Thank you for reporting this issue. We pushed https://github.com/jfrog/jfrog-client-go/pull/69 to the dev branch. It basically removes the problematic GetConfig().GetUrl() API, because the GetConfig().GetArtDetails().GetUrl() API can be used instead. You should already be able to use it, even before this fix is released. Looking forward to your feedback.

[susannamartinelli]

Thanks a lot @eyalbe4 I'll try that.