jfrog-client-go icon indicating copy to clipboard operation
jfrog-client-go copied to clipboard

Add error assertion for files/FindUpstream chdir functions

Open sverdlov93 opened this issue 3 years ago • 1 comments

Is your feature request related to a problem? Please describe.

Add error assertion for findUpstream() chdir functions. Simple assert ( if err != nil ... ) won't be enough, the logic should be changed.

Same on GetProjectRoot()

sverdlov93 avatar Dec 20 '21 15:12 sverdlov93

This is probably fixed by https://github.com/jfrog/jfrog-client-go/pull/537

However, the nebulous comment "the logic should be changed" may mean that there should be some further enhancements which have not been considered.

SteveNewson avatar Aug 11 '22 11:08 SteveNewson