Cannot follow example as UploadParams is not correctly initialized by NewUploadParams

[beiriannydd]

In order to properly initialize UploadParams, it must include a new instance of the substructure included only as a reference within UploadParams.

Without it, you get a SIGSEGV when trying to write to uninitialized memory for eg. Pattern or ExcludePatterns

However, the code is:

    func NewUploadParams() UploadParams {
    	return UploadParams{}
    }

[beiriannydd]

A simple solution to this would be to remove the * and include the structure directly. I don't think UploadParams is remotely useful without the Common parameters.

[barbelity]

Thanks @beiriannydd for these suggestions. #50 is now merged into the dev branch and should resolve this issue for all types of params. As you can see there, we decided to initialize ArtifactoryCommonParams when creating the params objects. Your feedbacks are highly appreciated.

[eyalbe4]

@beiriannydd - the latest release includes this change.