jfrog-cli icon indicating copy to clipboard operation
jfrog-cli copied to clipboard

feat: Validate Config Existence in config rm

Open bpujol opened this issue 1 year ago • 1 comments

Enhanced the config rm command to check if the specified configuration exists before attempting to remove it. Modified the deleteCmd function in config/cli.go to include a call to validateServerExistence, ensuring the configuration is present. If the configuration does not exist, the command now returns an error, preventing further execution and improving user feedback.

This change addresses user concerns about the lack of feedback when removing non-existent configurations, providing a clearer and more robust user experience.

  • [ x] All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • [x ] The pull request is targeting the dev branch.
  • [x ] The code has been validated to compile successfully by running go vet ./....
  • [x ] The code has been formatted properly using go fmt ./....

bpujol avatar Aug 02 '24 13:08 bpujol


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

github-actions[bot] avatar Aug 02 '24 13:08 github-actions[bot]

This pull-request was closed due to 7 days of inactivity after being marked as stale. Feel free to reopen it if it remains relevant.

github-actions[bot] avatar Oct 05 '25 00:10 github-actions[bot]