jfrog-cli icon indicating copy to clipboard operation
jfrog-cli copied to clipboard

Run go mod tidy

Open SuperSandro2000 opened this issue 1 year ago • 3 comments

Otherwise certain go commands complain that the go mod is wrong and needs fixing.

  • [ ] All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • [ ] The pull request is targeting the dev branch.
  • [ ] The code has been validated to compile successfully by running go vet ./....
  • [ ] The code has been formatted properly using go fmt ./....

SuperSandro2000 avatar Apr 20 '24 19:04 SuperSandro2000

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Apr 20 '24 19:04 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

SuperSandro2000 avatar Apr 20 '24 19:04 SuperSandro2000

Hey @SuperSandro2000,

Thanks for submitting the PR.

We've recently updated the CLI to Go 1.22.3, which should resolve the issue you encountered. We didn't merge your PR since updating the Go version affects some of our internal release tools.

I'm closing this pull request, but feel free to reach out if you have any questions.

EyalDelarea avatar May 23 '24 11:05 EyalDelarea

We didn't merge your PR since updating the Go version affects some of our internal release tools.

Newer go versions are a lot more strict about using older or newer versions for no good reason sadly...

Now I am encountering the following but I can work around that

 ▶ go mod tidy
go: go.mod requires go >= 1.22.3 (running go 1.22.2; GOTOOLCHAIN=local)

The new go toolchain changes are annoying....

SuperSandro2000 avatar May 23 '24 11:05 SuperSandro2000