jfrog
feat: support go1.22 build
- [ ] All tests have passed. If this feature is not already covered by the tests, new tests have been added.
- [ ] The pull request is targeting the
devbranch. - [ ] The code has been validated to compile successfully by running
go vet ./.... - [ ] The code has been formatted properly using
go fmt ./....
- relates to https://github.com/Homebrew/homebrew-core/pull/163578
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@chenrui333, The teats failures are probably caused because the go version should also be updated in the workflows under https://github.com/jfrog/jfrog-cli/tree/dev/.github/workflows
Also notice @chenrui333 that I have changed the target branch of this PR from v2 to dev. According to our Contribution Guidelines, PRs should be created for the dev branch.
@eyalbe4 hmm, sorry, I missed it, I was just using whatever default head branch.
@chenrui333, There are also additional tasks that are related to JFrog CLI's release process before JFrog CLI can be released with go 1.22. We will be handling them internally, and there's a chance this PR's merge will need wait a bit till we get this work done.
@eyalbe4 I have refreshed the PR with the latest dev branch, let me know if it works for you now. Thanks! :)
@eyalbe4 I have refreshed the PR with the latest dev branch, let me know if it works for you now. Thanks! :)
Hey @chenrui333,
Thank you for this PR, but unfortunately updating the go version only in the CLI is not enough.
I'm currently working on updating the CLI to Go 1.22.x. It has to do with prerequisites which are internal to JFrog, and updating all of the CLI components go versions. I will update you once the CLI Go version has been updated.
Thank you very much for your contribution!
It has to do with prerequisites which are internal to JFrog, and updating all of the CLI components go versions. I will update you once the CLI Go version has been updated.
that makes sense, @EyalDelarea any timeline for this (so that I can remove the go1.22 build patch on the brew side)
It has to do with prerequisites which are internal to JFrog, and updating all of the CLI components go versions. I will update you once the CLI Go version has been updated.
that makes sense, @EyalDelarea any timeline for this (so that I can remove the go1.22 build patch on the brew side)
Don't have an exact timeline, but hoping until next CLI release the go version will be updated as well. Will keep you updated here 👍
Hey @chenrui333
We just released the new CLI version v2.57.0 which uses Go 1.22.3
I'm closing this pull request, but feel free to reach out if you have any questions.