jenkins-artifactory-plugin icon indicating copy to clipboard operation
jenkins-artifactory-plugin copied to clipboard

Published 20 hours ago • verified publisher icon jfrog

resolve customBuildName with environment

Open peshay opened this issue 5 years ago • 11 comments

In case you want to override the Build Name, it can also be enhanced by environment variables.

peshay avatar Aug 13 '18 14:08 peshay

https://issues.jenkins-ci.org/plugins/servlet/mobile#issue/JENKINS-46171

peshay avatar Aug 13 '18 20:08 peshay

Thanks for this PR @peshay! Can you please join our contributors community by signing JFrog's CLA so that we can merge your code?

eyalbe4 avatar Sep 04 '18 09:09 eyalbe4

@eyalbe4 Actually I already did that. But I just did it again. And thank you if it can get merged. :)

peshay avatar Sep 04 '18 09:09 peshay

Thanks @peshay. Which name is the CLA signed with? Your github account includes only peshay.

eyalbe4 avatar Sep 05 '18 11:09 eyalbe4

Andreas Hubert

peshay avatar Sep 05 '18 11:09 peshay

@eyalbe4 where you able to review my changes? Anything else that I should consider etc.?

peshay avatar Feb 12 '19 12:02 peshay

@eyalbe4 any news or comments to my recent changes?

peshay avatar Aug 01 '19 13:08 peshay

Happy new year @eyalbe4 :) Maybe my Pull Request could be considered? Would be great, so I don't have to remerge and build my own plugin version ;) Thanks

peshay avatar Jan 24 '20 10:01 peshay

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

:x: peshay
:x: Andreas Hubert

Andreas Hubert seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 11 '20 14:06 CLAassistant

@peshay, Are you planning to continue working on this?

eyalbe4 avatar Jul 21 '20 12:07 eyalbe4

@eyalbe4 I am not a full time developer, so it's hard for me to implement your suggestions. It would take some time for me to work into this topic again. I would hope someone else could finish this task for me with more development experience. Still this is a functionally is one I need and I patch this branch into my Jenkins Projects for a while. tldr: If there won't be anyone else implementing such a feature, I may work on it again in a few months or so ...

peshay avatar Jul 22 '20 10:07 peshay