froggit-go icon indicating copy to clipboard operation
froggit-go copied to clipboard

http. RoundTripper is not re-used

Open pavelmemory opened this issue 2 years ago • 1 comments

For the bitbucketserver and github vcsclient(s) the http.RoundTripper is not re-used, but created for each new request if client.vcsInfo.Token is provided.
This can cause an issue because connections acquire file descriptors and won't be released immediately after http.Client garbage collection, please see https://golang.org/src/net/http/transport.go#L68

pavelmemory avatar Nov 09 '21 09:11 pavelmemory

@pavelmemory, Thanks for reporting this issue. We'd be happy to accept a fix for this issue through a pull request.

eyalbe4 avatar Jan 26 '22 19:01 eyalbe4