charts icon indicating copy to clipboard operation
charts copied to clipboard
verified publisher icon jfrog

[artifactory-ha] set as version value after the last colon

Open malamin opened this issue 1 year ago • 5 comments

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [x] Chart Version bumped
  • [x] CHANGELOG.md updated
  • [x] Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it: incorrect value is set as a chart version when images are downloaded from DNS containing the port number, which makes helm deployment impossible without fixing the chart with kustomize (e.g. in case of 'test.jfrog.io:8085/example:123' in the artifactory-ha statefulset the version is set as '8085/example' instead of '123')

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

malamin avatar Jun 11 '24 15:06 malamin

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Jun 11 '24 15:06 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

malamin avatar Jun 11 '24 15:06 malamin

recheck

malamin avatar Jun 11 '24 15:06 malamin

Hi @malamin,

Thank you reporting this issue, we have taken this internally. We will fix this in upcoming release and update you

oumkale avatar Jun 12 '24 08:06 oumkale

image Looks like the fix was released with version 107.84.16

dosilyoun avatar Jul 02 '24 10:07 dosilyoun

fixed via #1907

chukka avatar Jul 30 '24 04:07 chukka