charts
charts copied to clipboard
[artifactory] Add the ability to set `signedUrlExpirySeconds` to google providers
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
- [x] Chart Version bumped
- [x] CHANGELOG.md updated
- [x] Variables and other changes are documented in the README.md
- [x] Title of the PR starts with chart name (e.g.
[artifactory]
)
What this PR does / why we need it:
We are using the google-storage-v2-direct
provider and were previously providing a custom binary store with a signedUrlExpirySeconds
set to 120
. We recently switched to the chart-provided binary store config and can no longer control the signed URL expiry. As such, we are now using the provider default of 30
.
We've recently ran into issues where we would like to increase the expiry a bit, and we're not currently able to due to the binary store template provided by the chart not providing this ability. We would rather not go back to a custom-defined binary store config, so I'm raising this PR to address that.
Special notes for your reviewer:
I made signedUrlExpirySeconds
conditional on the value being set in a Helm deployment. I was going to add .artifactory.persistence.googleStorage.signedUrlExpirySeconds: 30
to /stable/artifactory/values.yaml, and remove the conditional from the binary store template, but figured this approach would be better so that, if not set, we can just rely on the built-in provider default without having to manage it within this Helm chart.
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
I have read the CLA Document and I hereby sign the CLA