charts icon indicating copy to clipboard operation
charts copied to clipboard

[xray]Added support for service account annotations

Open evanshoshan opened this issue 1 year ago • 6 comments

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [x ] Chart Version bumped
  • [x ] CHANGELOG.md updated
  • [ x] Variables and other changes are documented in the README.md
  • [x ] Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:

This PR allows for the configuring of service account annotations.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

evanshoshan avatar Nov 20 '23 16:11 evanshoshan

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Evan Shoshan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

github-actions[bot] avatar Nov 20 '23 16:11 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

evanshoshan avatar Nov 20 '23 16:11 evanshoshan

recheck

evanshoshan avatar Nov 27 '23 14:11 evanshoshan

I have read the CLA Document and I hereby sign the CLA

evanshoshan avatar Dec 01 '23 17:12 evanshoshan

This would be very helpful, I'm having to create my own Service Account to add annotations. Is anyone from JFrog able to give an update?

rhys96 avatar Jul 01 '24 17:07 rhys96

@evanshoshan Thanks for the PR. We will check this internally and will fix this in the upcoming versions of Xray. cc @rahulsadanandan

megha1906 avatar Jul 10 '24 09:07 megha1906