charts icon indicating copy to clipboard operation
charts copied to clipboard

[xray] add defaultRetentionDaysForIndexedRepo support

Open gregoryboue opened this issue 1 year ago • 9 comments

PR Checklist

  • [x] Chart Version bumped
  • [x] CHANGELOG.md updated
  • [x] Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:

Currently the Xray indexing default retention period can be defined in Xray System yaml with server.repo.defaultRetentionDaysForIndexedRepo settings.

If we want to configure this settings, we have to override xray system yaml (see systemYamlOverride), so it would be great to be able to configure this setting via a value in the chart's values.yaml file.

Which issue this PR fixes : fixes #1832

gregoryboue avatar Oct 19 '23 12:10 gregoryboue

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

github-actions[bot] avatar Oct 19 '23 12:10 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

gregoryboue avatar Oct 19 '23 12:10 gregoryboue

Is there anyone to review ?

gregoryboue avatar Oct 25 '23 22:10 gregoryboue

@gregoryboue Thanks for the PR. We will include this change in one of the upcoming releases.

rahulsadanandan avatar Oct 26 '23 07:10 rahulsadanandan

@gregoryboue Thanks for the PR. We will include this change in one of the upcoming releases.

Hi, do you have any information about the release date ?

gregoryboue avatar Nov 13 '23 09:11 gregoryboue

@rahulsadanandan , is this PR will be merged ?

gregoryboue avatar Dec 06 '23 19:12 gregoryboue

@rahulsadanandan any news ?

gregoryboue avatar Dec 15 '23 09:12 gregoryboue

@gregoryboue

We're exploring the concept of structured system YAML as part of another PR (https://github.com/jfrog/charts/pull/1842). This method enables us to modify individual system YAML parameters without the need to supply the entire system YAML block.

rahulsadanandan avatar Dec 15 '23 10:12 rahulsadanandan

@rahulsadanandan Thanks for the answer, it would be a very useful feature for us, i will waiting for it.

The ETA is for Q1 2024, do you have any precision about the month ?

gregoryboue avatar Dec 21 '23 08:12 gregoryboue

@gregoryboue Recently have merged a feature (https://github.com/jfrog/charts/pull/1842) that allows overriding the system YAML with the extraSystemYaml section. The entries specified under ‘xray.extraSystemYaml’ will be merged with files/system.yaml to generate the final system.yaml. This change is available from Xray version 103.95.x onwards.

rahulsadanandan avatar Jul 08 '24 10:07 rahulsadanandan