charts icon indicating copy to clipboard operation
charts copied to clipboard

Nginx deployment should not re-use the same serviecaccount as the artifactory statefulset

Open bramaq opened this issue 2 years ago • 1 comments

Is this a request for help?:


Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Version of Helm and Kubernetes: any

Which chart: artifactory 107.46.3

Which product license (Enterprise/Pro/oss): Enterprise

What happened: When deploying artifactory via the stable/artifactory helm chart with Nginx enabled, the nginx pods are created using the same service account used by the artifactory pods. This is incorrect as both nginx and artifactory pods have the same "identity" from the k8s point of view.

What you expected to happen: Artifactory pods and nginx pods should have their own (unique service accounts).

How to reproduce it (as minimally and precisely as possible):

helm install artifactory jfrog/artifactory --set nginx.enabled=true

kubectl get deploy artifactory-artifactory-nginx -o jsonpath='{.spec.template.spec.serviceAccount}' 
artifactory

kubectl get sts artifactory -o jsonpath='{.spec.template.spec.serviceAccount}' 
artifactory

Anything else we need to know:

bramaq avatar Oct 19 '22 10:10 bramaq

Thank you for pointing that out. we will take up this request internally. Further, feel free to raise a PR if you would like to contribute.

shahiinn avatar Oct 21 '22 10:10 shahiinn