[artifactory-oss] Artifactory Template does not respect setting the storageClassName or Size

[danmanners]

Description

When deploying Artifactory, I want to change both the storageClass and size of the deployed disk. However, updating the expected values in the values.yaml file does not change any of the default values.

Expected Behavior

I expect the values to be set to what I am defining.

Actual Behavior

The values are unchanged from their default settings. The disk size is unchanged, and the storageClass will ONLY use the default storage class.

Values to repeat issue

artifactory:
  # Installer Settings
  installer:
    platform: art-oss-helm

  # Artifactory Settings
  name: artifactory
  image:
    registry: releases-docker.jfrog.io
    repository: jfrog/artifactory-oss
  resources:
    requests:
      memory: "1Gi"
      cpu: "500m"
    limits:
      memory: "11Gi"
      cpu: "4"
  javaOpts:
    xms: "2g"
    xmx: "10g"

  persistence:
    enabled: true
    size: 60Gi
    storageClassName: nvme

Rendered Artifactory StatefulSet Output

...
  volumeClaimTemplates:
  - metadata:
      name: artifactory-volume
    spec:
      accessModes:
      - ReadWriteOnce
      resources:
        requests:
          storage: 20Gi

Screenshot

https://github.com/jfrog/charts/blob/7c0ad8e76fbeb64c40513eafc7a072d24fdb0f03/stable/artifactory/templates/artifactory-statefulset.yaml#L1341

Happy to provide any other information necessary.

[srinivasgowda097]

@danmanners : Since artifactory-oss is dependency chart of artifactory , you should use another artifactory field in values.yaml for example:

artifactory: 
     artifactory:
         volumeClaimTemplates : ....

please also share the complete values.yaml

[ghost]

I also have such an issue when updating the size of the volumeClaimTemplates: Kubernetes refuses it with an error:

My workaround at the moment is to delete the statefulset with --cascade=orphan (so that the pods are not terminated) before the helm upgrade. Afterwards, I manually resize the PVCs

[danmanners]

@srinivasgowda097 my deployment values.yaml file is deployed here: https://github.com/danmanners/homelab-kube-cluster/blob/main/manifests/workloads/artifactory-oss/values.yaml

If you step up to the directory, you can see the entire way I'm deploying it.

[srinivasgowda097]

@danmanners : Add another artifactory node at https://github.com/danmanners/homelab-kube-cluster/blob/main/manifests/workloads/artifactory-oss/values.yaml#L17 as below

artifactory: 
     artifactory:

[danmanners]

I've updated the values file as you suggested, but it does not appear to have fixed things. Happy to provide any other information to help troubleshoot this 🙂

[rahulsadanandan]

@danmanners i tried with your values i am able to see the values get updated in the rendered templates.

    ########## volumeClaimTemplates #######
  volumeClaimTemplates:
  - metadata:
      name: artifactory-volume
    spec:
      storageClassName: "nvme"
      accessModes: [ "[ReadWriteOnce]" ]
      resources:
        requests:
          storage: 60Gi

[rahulsadanandan]

is this a fresh installation or upgrade?

[chukka]

@danmanners is this still an issue ?

[danmanners]

Hey sorry for the delay, this slipped through the cracks.

No, after adding the additional nested artifactory.artifactory it appears to have been fixed.

Good to close, thanks folks.