[artifactory, artifactory-ha] Allow disabling eventual upload mechanism

[rkevin-arch]

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• [ ] Chart Version bumped
• [ ] CHANGELOG.md updated
• [x] Variables and other changes are documented in the ~README.md~ values.yaml
• [x] Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it: Add a artifactory.persistence.eventual.enabled flag that's default true. The official docs says direct upload (without the eventual upload mechanism) is recommended if Artifactory is hosted on AWS. Currently binarystore.xml is hardcoded to always have the eventual binary provider, so this PR adds a flag to disable it if needed.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): None

Special notes for your reviewer: I tested via a simple helm template with the following:

artifactory:
  persistence:
    type: aws-s3-v3
    eventual:
      enabled: false # toggle this

There are some whitespace changes with artifactory.persistence.eventual.enabled=true compared to before the PR but I think that's fine. Let me know if that needs to be fixed.

Also, the artifactory.persistence.eventual.numberOfThreads option seems to be unused and I found no references to it anywhere. Should I remove it from values.yaml?

[chukka]

@rkevin-arch Thanks for the PR , we will review this internally and come back shortly

[gitta-jfrog]

@rkevin-arch Hi, Thanks for your efforts. We are working on a new implementation of the binarystore.xml in our helm charts with support Direct (eventual-less) Upload Mechanism. This functionality exists only for Azure and AWS S3 BinaryProvider.

In the meantime, you can use the Direct (eventual-less) binary providers with "customBinarystoreXmlSecret" as described here

Br, Yarden JFrog Support

[bmanuel]

@gitta-jfrog are there any updates on JFrog's version of this change?

[gitta-jfrog]

Hi @bmanuel , Artifactory v7.46.3 was released last week, with the support of "direct" binary providers in both of our charts. For AWS S3 Direct upload you should use the "s3-storage-v3-direct" binary provider.

[bmanuel]

Thanks @gitta-jfrog. Should this be closed then with a link to the changelog item?

[chukka]

Fixed via https://github.com/jfrog/charts/pull/1682