charts icon indicating copy to clipboard operation
charts copied to clipboard

[artifactory] Add cluster-s3-storage-v3 support for S3

Open mheder79 opened this issue 3 years ago • 4 comments

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [ x] Chart Version bumped
  • [ x] CHANGELOG.md updated
  • [ ] Variables and other changes are documented in the README.md
  • [ x] Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it: The artifactory chart advertise as a replacement of artifactory-ha, but the artifactory chart do not have the capability to configure cluster-s3-storage-v3 for S3.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1591

Special notes for your reviewer:

mheder79 avatar Mar 04 '22 13:03 mheder79

I have read the CLA Document and I hereby sign the CLA

mheder79 avatar Mar 04 '22 13:03 mheder79

@mheder79 Sorry for the delay, we are reviewing this PR internally and will be mostly part of artifactory 7.40.x release if every thing looks good

chukka avatar May 19 '22 01:05 chukka

@mheder79 could you please look at these examples as an alternative approach using k8s secrets

chukka avatar May 19 '22 01:05 chukka

Hi @chukka

yes I can, but the question is for what purpose? Of course I can create my binarystore. But comparing the artifactory-ha chart with artifactory chart there is a function degradation. The "ha" can handle the cluster storage and "non-ha" cannot. My proposal is to add the "ha" functionality to this chart.

Thx,

mheder79 avatar May 25 '22 08:05 mheder79

@mheder79 I think this support is handled via #1682 , please verify and close this one

chukka avatar Oct 19 '22 05:10 chukka

Done in #1682

mheder79 avatar Oct 19 '22 18:10 mheder79