charts icon indicating copy to clipboard operation
charts copied to clipboard

[Artifactory-ha] override logback.xml in a tracable way for future upgrades.

Open mohammad-hamaydeh opened this issue 4 years ago • 2 comments

Is this a request for help?:

YES


Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST

` <appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">

  <filter class="ch.qos.logback.classic.filter.ThresholdFilter">
           <level>WARN</level>
  </filter>

</appender>`

We are trying to override logback.xml to filter the console messages to level "WARN" or "ERROR" but in the same time we want every thing to logged to files . it does filter some of the messages for the services bit not all .

Also if we want to change the log level for some loggers , currently we create a configmap for logback.xml and copy it on start up but since the logback.xml is part of the docker image , there is not reference in the chart for the changes that could happen to this file , we would like to have this file exposed with the helm chart

Version of Helm and Kubernetes: version.BuildInfo{Version:"v3.2.1", GitCommit:"fe51cd1e31e6a202cba7dead9552a6d418ded79a", GitTreeState:"clean", GoVersion:"go1.13.10"}

Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.15", GitCommit:"2adc8d7091e89b6e3ca8d048140618ec89b39369", GitTreeState:"clean", BuildDate:"2020-09-02T11:40:00Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"16+", GitVersion:"v1.16.15-gke.7800", GitCommit:"cef3156c566a1d1a4b23ee360a760f45bfbaaac1", GitTreeState:"clean", BuildDate:"2020-12-14T09:12:37Z", GoVersion:"go1.13.15b4", Compiler:"gc", Platform:"linux/amd64"}

Which chart:

version: 4.9.1 appVersion: 7.15.3

What happened: currently we are able to override logback.xml , but we have a concern that we can't keep track of the changes since it is included part of the docker image and not exposed out in the helm chart What you expected to happen: we need to be able to control the logback.xml from the helm chart , as well the logback.xml part of the chart to be traceable for changes

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

mohammad-hamaydeh avatar Feb 23 '21 11:02 mohammad-hamaydeh

@mohammad-hamaydeh Thanks for the reporting this, will triage with our team internally and update on the next steps

chukka avatar Feb 24 '21 09:02 chukka

We would also like this feature, to allow for the addition of logging for plugins without having to maintain a copy of the entire logback.xml.

ghost avatar Jul 27 '21 19:07 ghost