build-info icon indicating copy to clipboard operation
build-info copied to clipboard

Published 20 hours ago • verified publisher icon jfrog

Correct .npmrc for newer versions of NPM

Open Spaction opened this issue 11 months ago • 15 comments

  • [x] All tests passed. If this feature is not already covered by the tests, I added new tests.

Replaces old _auth from the temp npmrc file conditionally if we are past or equal the version 8.19 which introduced the new format.

Spaction avatar Mar 21 '24 08:03 Spaction

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Mar 21 '24 08:03 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

Spaction avatar Mar 21 '24 08:03 Spaction

I'm not part of the dev-ops team, but i'll mention to them that this Plug-in is not being as actively developed. As mentioned, the part where this should shine is with running against Node 15 and Node 20, where as before that would have failed.

Spaction avatar Mar 22 '24 04:03 Spaction

@eyalbe4 Any chance you can re-run the checks?

Spaction avatar Mar 25 '24 13:03 Spaction

@eyalbe4 Is there anything else needing to be done for this to be rechecked?

Spaction avatar Apr 02 '24 18:04 Spaction

@yahavi Are you able to re-execute the checks?

Spaction avatar Apr 02 '24 19:04 Spaction

@RobiNino @eyalbe4 Any change this can have the test re-run?

Spaction avatar May 03 '24 12:05 Spaction

@Spaction , Sorry for the delay, we'll review this soon

RobiNino avatar May 05 '24 06:05 RobiNino

Hi @Spaction , I took the liberty to update the PR with a few fixes to the tests infrastructure. I also temporarily changed the target branch so that the changes to the workflow made in this PR will reflect in the tests.

Seems like the npm tests are failing. Could you please look into it before we proceed? Thanks

RobiNino avatar May 22 '24 17:05 RobiNino

@RobiNino,

Updated the Unit tests. Can honestly say the test doesn't differ between between the NPMExtractor Test vs the one for NpmBuildInfo. The expanded test for the v15 vs v20 is what would have failed previously during the NPMExtractorTest. Only way to confirm this would be to expand only the unit test to include Node v20 and see that it fails for that branch. This is only to say that the new test can be excluded as the other indirectly tests the method\execution path in its npmCiTest

Spaction avatar May 28 '24 03:05 Spaction

@RobiNino Any updates on my last response?

Spaction avatar Jul 08 '24 14:07 Spaction

@RobiNino , @eyalbe4 Any update?

Spaction avatar Jul 19 '24 05:07 Spaction

@RobiNino , @eyalbe4 ?

Spaction avatar Jul 30 '24 21:07 Spaction

@Spaction, While we'd like to continue promoting this, the team is currently loaded with a few other initiatives and will get back to this when they become available. As a side note, Artifactory's build info integration with NPM and other package managers is strongly recommend by us through JFrpg CLI and not through this older java based build-info-extractor code. The JFrog CLI integration is already more stable, has better support for NPM and receives a lot more attention from the community and the dev teams.

eyalbe4 avatar Jul 31 '24 04:07 eyalbe4

@eyalbe4 You mentioned that back in March, to which I'll repeat what I said earlier. I've no control over what tools we use. I've brought up to the team responsible to use the newer library and for reasons I won't state here was told it would not be happening.

Spaction avatar Jul 31 '24 04:07 Spaction