build-info-go icon indicating copy to clipboard operation
build-info-go copied to clipboard

fix: same vcs info appened twice when running jf rt build-add-git command twice

Open gerrnot opened this issue 10 months ago • 5 comments

  • [x] All tests passed. If this feature is not already covered by the tests, I added new tests.
  • [x] All static analysis checks passed.
  • [x] This pull request is on the dev branch.
  • [x] I used gofmt for formatting the code before submitting the pull request.

gerrnot avatar Apr 19 '24 09:04 gerrnot

@eyalbe4 Thanks! I found evidence that this whould be fixed by a go upgrade, so I merged the already approved (at least partly) sibling PR: https://github.com/jfrog/build-info-go/pull/249

gerrnot avatar Apr 19 '24 11:04 gerrnot

Hey @gerrnot

We've just update to go 1.22.3, Can you confirm that the issue is resolved by updating the go version?

EyalDelarea avatar May 29 '24 11:05 EyalDelarea

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Jun 03 '24 16:06 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

gerrnot avatar Jun 03 '24 16:06 gerrnot

@EyalDelarea Thanks, yes, the build was green after that. I rebased.

gerrnot avatar Jun 03 '24 18:06 gerrnot