artifactory-user-plugins icon indicating copy to clipboard operation
artifactory-user-plugins copied to clipboard

Add all repos if non given

Open derhecht opened this issue 5 years ago • 6 comments

like cleanup script

derhecht avatar Aug 13 '19 11:08 derhecht

Hi @derhecht , thank you for your contribution.

I'm not very comfortable with adding behavior when some configuration value is missing. I think It can hide configuration mistakes and provide an undesired result. This is specially important in cases like this where we are deleting things from the server.

I would like to suggest the usage of a key word, something like ALL, to be used by the user to set the repo/path list parameter when looking for the behavior added by you. We also need to document that as a possible configuration value in the README file.

elioengcomp avatar Aug 13 '19 16:08 elioengcomp

Excellent change! Picked up for my RT

calvinpark avatar Sep 09 '19 14:09 calvinpark

Hi @derhecht , thank you for your contribution.

I'm not very comfortable with adding behavior when some configuration value is missing. I think It can hide configuration mistakes and provide an undesired result. This is specially important in cases like this where we are deleting things from the server.

I would like to suggest the usage of a key word, something like ALL, to be used by the user to set the repo/path list parameter when looking for the behavior added by you. We also need to document that as a possible configuration value in the README file.

Hi @elioengcomp may have a look at this approach?

derhecht avatar Jun 19 '20 17:06 derhecht

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 20 '20 14:06 CLAassistant

ok, added email address to my account, signed CLA, recheck seems not to work...

derhecht avatar Jun 22 '20 07:06 derhecht

got it. finally.

derhecht avatar Jun 22 '20 14:06 derhecht