Jonas Freißmann

Results 19 comments of Jonas Freißmann

Thank you for finding the erroneous `"type"` references. Some were definitely wrong, but a great chunk were including the economizer type, which was a design decision, as the `"type"` field...

I really like the idea of the model_registry and the way you were able to reduce the test code. I think, we will have to look into how users, who...

> ```python > from heatpumps.parameters import get_params, get_model > > params = get_params('HeatPumpEconIHXClosed') > params['ihx']['dT_sh'] = 7.5 # superheating by internal heat exchanger > hp = get_model(params) > print(hp) >...

> One more side note: right now all json files are loaded on startup, this takes a bit of time. I suggest, that the data can be loaded on demand...

On another note: As you most likely inserted the dashboard info programmatically into the input parameters, there was an issue with UTF-8 encoding, so umlauts are not correctly inserted. See...

Thank you for the constructive feedback! We used `matplotlib` for the states diagrams because of `fluprodia` and `plotly` for the sankeys as `TESPy` does so. `matplotlib` also offers interactive capabilities,...

Hey Timo :) Thank you for all of the constructive feedback! I have been thinking of condenser subcooling for a while as well, but haven't been able to implement it...

I concur. We were unsure how to set a sensible limit that makes sure users don't break the simulation and weren't sure how a more generous yet easily calculatable limit...

I have to back track here a bit, as I was confusing your issue with a similar hard limit set for transcritical cycles. The problem you are highlighting here stems...