jfreechart-fse icon indicating copy to clipboard operation
jfreechart-fse copied to clipboard

SpiderWebPlot markers, CategoryPlot optional fixed category size, Force directed labeling algorithm for XY charts

Open ripdajacker opened this issue 10 years ago • 14 comments

Hey

In my company we have made quite a number of changes:

CategoryPlot can have fixed category size (2010) This change was made using a patch found on the sourceforge mailing list for JFreeChart a few years ago, so I won't take credit for this. We draw most of our charts on PDF canvas, and a fixed category size lets us create bar charts with the same bar width/spacing throughout the document.

SpiderWebPlot has interval paints and markers with names (2012) It's now possible to add intervals in the form of rings in the plot along with category markers. An example of the features is seen here: Imgur

Force directed labeling algorithm (2013-2014) We had troubles using XY charts due to the labels were all over the place. We did some research and found this article with corresponding Java code: https://www.ads.tuwien.ac.at/research/labeling/ .

The licensing was not compatible with JFreeChart so I contacted the authors and got their written permission to use the (albeit refactored) code under the LGPL.

A colleague of mine did the code import. The result is a new implementation of XYLineAndShapeRenderer called org.jfree.chart.renderer.xy.XYAutomaticLabelPlacementRenderer

All these features are used in our production systems, so we are quite confident that we have ironed out most of the bugs.

I've made an effort to merge our two source trees as close as they can get, and I hope you merge our changes.

ripdajacker avatar May 21 '14 11:05 ripdajacker

David Gilbert » jfreechart-fse #95 UNSTABLE Looks like there's a problem with this pull request (what's this?)

buildhive avatar May 21 '14 11:05 buildhive

David Gilbert » jfreechart-fse #96 UNSTABLE Looks like there's a problem with this pull request (what's this?)

buildhive avatar May 21 '14 12:05 buildhive

David Gilbert » jfreechart-fse #97 UNSTABLE Looks like there's a problem with this pull request (what's this?)

buildhive avatar May 21 '14 12:05 buildhive

I've fixed a couple of the tests that were broken, but can't seem to figure out why ValueAxisTest#test3555275 fails. That's the only one left.

https://buildhive.cloudbees.com/job/jfree/job/jfreechart-fse/org.jfree.chart$jfreechart-fse/97/testReport/org.jfree.chart.axis/ValueAxisTest/test3555275/

ripdajacker avatar May 21 '14 12:05 ripdajacker

Just one hint: you (or probably your IDE) did many whitespaces only changes. This is very annoying, increases the patch-size and hides the actual changes. It would be much better if you could revert these changes.

matinh avatar May 21 '14 13:05 matinh

David Gilbert » jfreechart-fse #98 UNSTABLE Looks like there's a problem with this pull request (what's this?)

buildhive avatar May 21 '14 14:05 buildhive

David Gilbert » jfreechart-fse #99 UNSTABLE Looks like there's a problem with this pull request (what's this?)

buildhive avatar May 21 '14 14:05 buildhive

David Gilbert » jfreechart-fse #100 UNSTABLE Looks like there's a problem with this pull request (what's this?)

buildhive avatar May 21 '14 14:05 buildhive

David Gilbert » jfreechart-fse #101 UNSTABLE Looks like there's a problem with this pull request (what's this?)

buildhive avatar May 21 '14 14:05 buildhive

David Gilbert » jfreechart-fse #102 UNSTABLE Looks like there's a problem with this pull request (what's this?)

buildhive avatar May 21 '14 15:05 buildhive

David Gilbert » jfreechart-fse #103 UNSTABLE Looks like there's a problem with this pull request (what's this?)

buildhive avatar May 21 '14 15:05 buildhive

I've tried to minimize the line ending changes. From what I can see there are only changes to line endings/whitespace in the files that have code changes too.

ripdajacker avatar May 21 '14 15:05 ripdajacker

David Gilbert » jfreechart-fse #104 UNSTABLE Looks like there's a problem with this pull request (what's this?)

buildhive avatar May 21 '14 15:05 buildhive

David Gilbert » jfreechart-fse #105 UNSTABLE Looks like there's a problem with this pull request (what's this?)

buildhive avatar May 21 '14 15:05 buildhive