jfreechart-fse
jfreechart-fse copied to clipboard
jfree
Replaced assertNotEquals with assertNotSame to fix compile error.
Sure hope I am using "Git" properly! Sorry for any mistakes I might make! :-> I would like to contribute to this project, so I cloned the repository, created a NetBeans project, and saw right away that there was a problem with this file. So I figured this would be a good way to A) contribute a fix, and B) test my knowledge of Git.
As far as I can tell, you are using GitHub correctly (I am no expert myself). I don't see the compile error on a fresh clone of the project, though, so I am wondering how you are getting the error. With Netbeans you should be able to simply open the pom.xml file and build and run...is that the way you did it, or did you create a project manually? If it is the latter, what version of JUnit do you have?
I actually didn't know that NetBeans supported "pom" - honestly not sure what pom is, lol...I will have to look into that!
I figured out the problem though: I had an old version of junit.jar in the lib subdirectory, and even though I had added the NetBeans plugin for JUnit to the list of libraries, it must have seen the old junit.jar first and used that for building. So I did a clean on the project, removed the old jar file from the directory, reverted the change to AxisTest back to what it used to be, then did a build.
Haha - oops! False alarm! :->
But I've got the general process correct, right? That is: 1) Make a change, fix a bug, whatever, 2) when it's ready, do a commit to my local repository. 3) Then push to the remote repository. 4) Then create a "pull request". I'm guessing that is what notifies you that there is a change, and then you can accept it or not?
Thanks! Is there any specific task repository, such as bugzilla, to go look for ways to contribute? I know there is a link to a forum off the jfree.org website, but not sure if that's what's being used to track changes made to the fse.
@tracylynne99 Please see David's answer to my question I asked some time ago. http://www.jfree.org/phpBB2/viewtopic.php?f=3&t=116641 You have two places where jfree codes are stored. One on sourceforge and from that place new relases are created. Open issues for that are here http://sourceforge.net/p/jfreechart/bugs/?source=navbar . What you have on github is a development repository only, though I commited there one patch and asked David to add it to the currently planned release. Correct me @jfree if I'm wrong. Greetings.
David Gilbert » jfreechart-fse #88 FAILURE Looks like there's a problem with this pull request (what's this?)
Whoops, what did I do wrong? I looked at the output on build hive and all I could see was that there are merge errors, but it didn't give any more detail (that I could see) than that.
Anyway...sorry! :-\
So I never heard back from anyone about why the pull request failed - did I merge something incorrectly? Should I go ahead and delete my forked repo and try again (now that I understand Git a little bit better...)? Please advise, thanks!
Ok...just undid the commits for unneeded changes (such as where I only made comment changes). Hopefully I still preserved the ParamCheck changes I merged in. I was thinking I'd make a new pull request, but Git doesn't seem to want to let me do that... hmmmm.
I just tried the merge and I get a lot of conflicts...I will see how far I can get fixing them.
Oh - sorry about that! That's the exact opposite of what I wanted! If you want me to, I can just delete my fork/branch (once I figure out how!) and just start all over again - might be easier...