requirejs-mustache icon indicating copy to clipboard operation
requirejs-mustache copied to clipboard

add bower.json with dependencies on requirejs-text and mustache

Open maxenglander opened this issue 11 years ago • 3 comments

Hey @jfparadis, thanks for the useful plugin. I'm using bower to manage my dependencies. It would be great if your plugin supported bower. At a minimum, you'd need to create a tag (like 0.0.0) and merge this PR, and ideally register your plugin with bower register as well.

maxenglander avatar Jun 24 '13 00:06 maxenglander

What if you want to use requirejs-text in your own code? What if you need a different version? You would have to include multiple versions of the same script. I think the best approach is adding it to bower with no dependencies and leaving a guide to setting up Mustache and requirejs-text in your own code.

The current approach seem the most flexible to me. Although I would like to see official bower support with version tags.

Olical avatar Jul 28 '13 14:07 Olical

@Wolfy87 Not sure I follow. This PR would allow the bower user to use whatever mustache and requirejs-text versions they wanted, as long as they are above (the pretty generous) minimum.

maxenglander avatar Jul 28 '13 23:07 maxenglander

Just a quick update, I've been reviewing the changes and I will port them to the 3 implementations of requires + template engine to keep feature parity. I though I thought I'd be done last week-end but there were lots of things on my end to clean-up, and I wanted to ramp-up on bower to have an educated opinion and accept the submission.

jfparadis avatar Sep 09 '13 23:09 jfparadis