UnpluggedSegy icon indicating copy to clipboard operation
UnpluggedSegy copied to clipboard

Coordinates

Open Andrei-Errapart opened this issue 2 years ago • 4 comments

This is my first pull request over who knows how many years. All comments are welcome.

There are fields for the X,Y coordinates in TraceHeader and ITraceHeader now.

The library has been updated to use PackageReferences as does everyone these days.

Speed optimization of about 2x. This is noticeable when reading from NVME disks.

Andrei-Errapart avatar Jan 08 '23 20:01 Andrei-Errapart

Thanks, Andrei. It has been so long since I looked at this project. I know a lot of things are out of date. I'll try to have a look.

One thing I'll say is we should try to use C# idioms / naming conventions. So we don't typically have names that are all caps or have underscores. Have a look at: https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/coding-conventions

Do you have any small sample SEGY files you can provide that are good test cases for your new features?

Thanks for your contribution.

jfoshee avatar Jan 27 '23 16:01 jfoshee

Most definitely I have some SEGY files.

Will try to find some time over the weekend.

Andrei-Errapart avatar Jan 27 '23 17:01 Andrei-Errapart

Hi, @Andrei-Errapart, sorry your PR has languished for so long. My consulting work always takes precedence. I'd like to spend a few cycles getting this project back up to date with .NET if it is still useful to you. Was this something you are using for research? Or commercial use? If commercial, would your employer be willing to sponsor a day's work? Cheers.

jfoshee avatar Feb 28 '24 16:02 jfoshee

Hi, no need to apologize, the ball was on my side and I haven't had the time for it.

It was used just to convert some files. Some further work was anticipated but it didn't realize. Thus, I haven't done anything with SGY since then.

Were we still actively involved with the SGY format, arranging compensation for the work would be feasible. In the foreseeable future, no.

I personally think that if one just wants to practice his/her coding/sw engineer skills, using UnpluggedSegy as a practice target makes sense - the possible failures impact a few people.

Andrei-Errapart avatar Mar 02 '24 11:03 Andrei-Errapart