JFoeniX

Results 50 comments of JFoeniX

Hi, can you specify the not so good casts of JFXKeyValue? Also I noticed in JFXAnimationKeyValue, all the suppliers/functions are dependent on the animation node, which I don't think is...

Regarding type safety for JFXKeyValue, I agree with you, it's better to make JFXKeyValue builder type safe. Moreover, how about combining these two classes JFXKeyValue/JFXAnimationValue? so it would be less...

I updated JFXKeyValue builder to ensure type safety and pushed the fix

I guess, maybe we need a better naming. I'm usually bad at naming but how about JFXAnimationTemplate? also I have some questions regarding the code: 1. JFXAnimationCreatorValue - if `noTarget`...

Hi @schlegel11, I'm trying to keep up with all these builder, however I keep getting lost. I have a question, what's the point of JFXAnimationTemplate? I mean this class is...

Also if you can provide some examples that cover all cases it would appreciated.

Yes I noticed the similarity between JFXAnimationTemplate and Timeline. but my question was, what's the point of having a builder for JFXAnimationTemplate when it only contains its builder as a...

@schlegel11 it looks good to me, however one more thing I noticed in `JFXAnimationTemplateAction`, you created `InitBuilder` to force calling the `target` method at the beginning, right? however there is...

I see your point, maybe its better to have a function here. For me all seems good, no more comments 👍 . Feel free to create a PR if you...

Hi, yes sure, I'll review the cutout and rippler changes and get back to you. Same for me :) thank you for such a cool feature :) Regards,