Jeroen Engels

Results 308 comments of Jeroen Engels

I would definitely recommend it in the docs. It can't hurt to have it in the rule output (as long as the message stays short), especially as the maintainers decided...

`t.end()` does not take arguments. If with `t.end(false)` you meant to fail the test, I'd suggest using `t.fail()` or throwing something instead. This issue is still active, nobody started working...

True, the message would be a lot nicer then (though even with a more generic rule, we can still have different error messages). Unless someone has other ideas of how...

Sounds like a good idea to me :+1:. Not sure when/why try/catch makes sense in tests when t.throws is available. The second example is better, but FYI, using `t.fail()` would...

I think that `t.throws()` handles every case you'd use a try catch for, and even the `Promise#catch()` case.

From the functions that I see available in the packages you linked, none of these libraries would be reported by this rule idea (based on "Example of things the rule...

I agree the idea can be specified a bit more. The aim of the rule is to report unused type variables, unused in the sense that it provides no value...

Hi @jpagex Thanks for creating the issue :slightly_smiling_face: I am not sure what the correct approach is here. In the example you gave here, the condition `Id a == Id...