ResourceHub icon indicating copy to clipboard operation
ResourceHub copied to clipboard

Added Error 404 page, along with a Home Page and About Us page for the website

Open r1shayanr7 opened this issue 1 year ago • 6 comments
trafficstars

IMPORTANT: When creating your Pull Request, please use the following format for the title: Category - Resource Name & Section

PR Title samples:

  • Web development - CSS Portal & Tools
  • Web development - Leetcode & Challenges

Fixes Issue

Fixes #134 Fixes #148 Fixes #139

Closes #134 Closes #148 Closes #139

Description:

Added Error 404-page along with a dedicated Landing Page for the website so that users can easily navigate to the GitHub repository, added About Us page too.

Screenshots:

Screenshot 2024-05-15 231643 Screenshot 2024-05-15 231649 Screenshot 2024-05-15 231656 Screenshot 2024-05-15 231709 Screenshot 2024-05-15 231716 Screenshot 2024-05-15 231723 Screenshot 2024-05-15 231734

Resource URL:

Checklist:

Before submitting your pull request, ensure that you have completed the following tasks:

  • [x] I have carefully reviewed and adhered to the contributing guidelines before creating this pull request.
  • [x] I followed the prescribed PR title template.
  • [x] I followed the Code of Conduct

r1shayanr7 avatar May 15 '24 18:05 r1shayanr7

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

github-actions[bot] avatar May 15 '24 18:05 github-actions[bot]

Why didn't you say that you could build the website? I thought you were just going to create the 404 page. I could have assigned it to you, but someone is already working on it. #166.

Maybe after the person assiged created an issue, you can develop and ehance the website since I like the design of thhe websitre tyou created.

jfmartinz avatar May 16 '24 00:05 jfmartinz

@jfmartinz I'm sorry, the error page needed a home page so I built it. If you merge this pull request the person already working maybe able to make changes on top of it. It will reduce the time taken and make it a lot faster.

r1shayanr7 avatar May 16 '24 06:05 r1shayanr7

@jfmartinz Should I create another pull request with Only the Error Page?

r1shayanr7 avatar May 16 '24 19:05 r1shayanr7

@jfmartinz Should I create another pull request with Only the Error Page?

Yes. If you can. But I like the website you built, maybe after the website is done building, then maybe you can help us make it more better, thanks

jfmartinz avatar May 17 '24 04:05 jfmartinz

What if you two #166 work together to create the website and speed it up, what do you think? Hes using HTML CSS JS and API to create the website, and I will give you booth level 3 for it?

jfmartinz avatar May 17 '24 05:05 jfmartinz

@jfmartinz That sounds like a good idea. So firstly, I'm creating another pull request with only the Error page so this issue gets closed, and then I will change the homepage in html, css, js stack and work with him.

r1shayanr7 avatar May 17 '24 07:05 r1shayanr7

Actually the guy said that the website is ready for the development, but I think you could help us for making it better? Maybe Ill c reate simple design and then well see. You can connect with me if you want here (linkedin)

jfmartinz avatar May 17 '24 15:05 jfmartinz

Sure @jfmartinz . I'll see if the website needs improvement after

r1shayanr7 avatar May 17 '24 19:05 r1shayanr7