Jeremy Fleischman
Jeremy Fleischman
As with #509, I'm opposed to this. IMO, it's something your text editor/IDE should be doing instead.
Thanks for the explanation! Please disregard my comment, I incorrectly assumed this was about automatically invoking treefmt when files change. It looks like @brianmcgee is supportive, so I'll wait to...
If we build this, we should name it so it's clear that it's a git specific thing, and probably error/warn if folks use it when not using a git walker....
> 2. Its forcing me to wrap eslint including its plugins into a derivation to pass it to treefmt. (Talking about usage in UI projects where people use npm, etc.)...
This feels out of scope for treefmt. The git dance you have to do to implement this `--check-staged-only` logic already exists in [pre-commit](https://pre-commit.com/). Even if we were to implement it...
> pre-commit install is super easy and native. You don't need external tools for simple setups. Just do: It's more than that, right? If there's already a symlink you need...
> Does treefmt.toml have no effect when using `treefmt` with `--stdin`? It does have an effect. If it did not, then `foo/bar.nix` wouldn't get formatted in your example (because treefmt...
IIRC, ~#53~ #573 is about threading the filename down to the underlying formatter, which requires an extension to our formatter specification (#586). Fixing this wouldn't require support from the underlying...
@brianmcgee quick ping here.
Urg, sorry. There was a typo on my message. I still don't see how #586 is relevant here. This feels to me like something entirely up to treefmt's walker implementation(s).