jflex icon indicating copy to clipboard operation
jflex copied to clipboard

Published 20 hours ago • verified publisher icon jflex-de

Re-enable check against FallThrough violations

Open regisd opened this issue 7 years ago • 7 comments

Fix #222 Fix #239

regisd avatar Sep 22 '18 15:09 regisd

IIRC, this can only be done with code generated with 1.8.0, hence can only be done in 1.9.0

regisd avatar Dec 08 '19 22:12 regisd

IIRC, this can only be done with code generated with 1.8.0, hence can only be done in 1.9.0

Makes sense, let's leave this here until 1.8.0 is out.

lsf37 avatar Dec 09 '19 04:12 lsf37

This seems to be passing even though bazel is still building with 1.7.0. Is this Ok to merge?

lsf37 avatar Mar 15 '20 05:03 lsf37

I'm afraid not. I tried to update to jflex-1.8 in the corp repository, and I get a number of errors. Sorry that I didn't take the time to investigate.

regisd avatar Mar 16 '20 18:03 regisd

No worries. Are the errors about fall-through or other jflex 1.8.0 things?

lsf37 avatar Mar 17 '20 01:03 lsf37

So, the scope of the suppress warning (either via @SuppressWarnings or via javacop -X:ep is only about FallThrough. I'm running a presubmit now.

regisd avatar Apr 10 '20 19:04 regisd

There are remaining violations on 1.8.0.

jflex/java/jflex/core/LexScan.java:2483: error: [FallThrough] Execution may fall through from the previous case; add a `// fall through` comment before this line if it was deliberate
            case 800: break;
            ^
    (see https://errorprone.info/bugpattern/FallThrough)

regisd avatar Apr 14 '20 08:04 regisd