node-ecstatic icon indicating copy to clipboard operation
node-ecstatic copied to clipboard

Fix redirections on Windows

Open Xmader opened this issue 5 years ago • 2 comments

Thank you for fixing Backport Open Redirect vulnerability, but it breaks on Windows machines.

path.normalize("/path/to/file") returns \path\to\file on Windows, and it doesn't work in browsers.

Xmader avatar Jun 05 '19 01:06 Xmader

Codecov Report

Merging #261 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   75.26%   75.26%           
=======================================
  Files          11       11           
  Lines         558      558           
  Branches      128      128           
=======================================
  Hits          420      420           
  Misses         51       51           
  Partials       87       87
Impacted Files Coverage Δ
lib/ecstatic.js 72.36% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ae7a39b...4d75eef. Read the comment docs.

codecov-io avatar Jun 05 '19 02:06 codecov-io

https://github.com/jfhbrook/node-ecstatic/issues/262

Xmader avatar Jun 15 '19 22:06 Xmader