ControllerTools icon indicating copy to clipboard operation
ControllerTools copied to clipboard

Cannot read property

Open dm82m opened this issue 1 year ago • 9 comments
trafficstars

With current steam beta client and pre release of decky it raises an TypeError Cannot read properties.

I guess it has something todo with: https://github.com/mcarlucci/decky-storage-cleaner/pull/10

dm82m avatar Mar 10 '24 07:03 dm82m

DFL needs to be bumped. See this specific comment of SteamDeckHomebrew/decky-loader#597. Thanks for your time.

TiZ-HugLife avatar Mar 17 '24 02:03 TiZ-HugLife

It's not happening "again", it's just still happening. All the breaking changes from beta got shoved out into stable, so now everything with Decky is everyone's problem.

TiZ-HugLife avatar May 08 '24 14:05 TiZ-HugLife

I'll look into updating DFL

jfernandez avatar May 08 '24 14:05 jfernandez

controller-tools-1.2.0.zip

Could one of you manually install this release candidate to see if it fixes the problem?

jfernandez avatar May 08 '24 14:05 jfernandez

This is what it says with that zip file installed 20240508_194317

costinvader avatar May 09 '24 01:05 costinvader

This is what it says with that zip file installed !

I'm experiencing the same issue with that zip file installed. Have you been able to find a solution or workaround?

vbali avatar May 09 '24 22:05 vbali

I'm not a developer, I just tested it, sorry bro

costinvader avatar May 09 '24 23:05 costinvader

I'm going to ask in their discord why you are still getting that error.

jfernandez avatar May 11 '24 21:05 jfernandez

controller-tools-1.2.0.zip

Could one of you manually install this release candidate to see if it fixes the problem?

not fixed

f3bandit avatar May 12 '24 19:05 f3bandit

The error I'm getting with version 1.2.0 is:

TypeError: plugin_export is not a function
       at PluginLoader.importReactPlugin (http://localhost:1337/frontend/chunk-ecb27f3b.js:6995:30)
       at async PluginLoader.importPlugin (http://localhost:1337/frontend/chunk-ecb27f3b.js:6969:17)

I quickly looked at your DFL update and it looked fine to me. Any idea on what else might cause this?

Nachtfrische avatar May 20 '24 12:05 Nachtfrische

I’m out of ideas. I’ve also asked in the Decky discord and they also believe the update looks good. I could use some help debugging this further if anyone wants to help out.

jfernandez avatar May 20 '24 12:05 jfernandez

If this helps, the notification when the battery drops under 15% is still working, only the interface to see what's the actual battery level of the controller is not working

costinvader avatar May 22 '24 05:05 costinvader

Well, what's missing to be updated or released ? It's a great plugin/feature and we all miss that :)

Nottinghster avatar May 26 '24 16:05 Nottinghster

according to aagaming on decky discord you dont need output.name in rollup.config.js, remove the line name: "ControllerTools", in the release candidate and see if that fixes it

ecogice avatar May 27 '24 04:05 ecogice

I removed that line from rollup.config.js. Here is the new release candidate. Please give it a try:

controller-tools-1.2.0.zip

jfernandez avatar May 27 '24 12:05 jfernandez

I removed that line from rollup.config.js. Here is the new release candidate. Please give it a try:

controller-tools-1.2.0.zip

Now it's working again ❤ screenshot

Nottinghster avatar May 27 '24 13:05 Nottinghster

yup works :) plugin wasnt showing up when i tried to build manually but all i had to do is delete the settings json for controllertools and reinstall decky

ecogice avatar May 27 '24 13:05 ecogice

Thanks for verifying. It looks like there is a small regression with the Refresh button, but since it's cosmetic I'll go ahead and release 1.2.0 with the fix.

jfernandez avatar May 27 '24 14:05 jfernandez